Fix #655: Always emit Turnstile domains, even when empty #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes more widgets, including more 'exotic' configs - and adds new response fields introduced over time.
When Turnstile is configured with an empty list of domains, no validation is performed by Cloudflare - the widget can be used anywhere. The website owner is responsible for validating the challenge was solved on the "right" website. This feature is gated behind an entitlement, and `domains = []` is used to enable this. This is *not* a default value for domains, it must be picked explicitly. Fixes cloudflare#655.
punkeel
force-pushed
the
punkeel/fix-655
branch
from
d9f0db1
to
f787ca4
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Turnstile is configured with an empty list of domains, no validation
is performed by Cloudflare - the widget can be used anywhere. The website
owner is responsible for validating the challenge was solved on the "right"
website.
This feature is gated behind an entitlement, and
domains = []is used toenable this. This is not a default value for domains, it must be picked
explicitly.