generate/load_balancer: correctly remap country_pools, region_pools and pop_pools
#584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s` and `pop_pools` Updates the `cloudflare_load_balancer` generation to remap the `country_pools`, `region_pools` and `pop_pools` to the nested block instead of the object/map field. This was a bit of tricky one to track down because the original response from the API _has_ the correct schema attributes but the kicker is that they are not a supported type (for good reasons!).
jacobbednarz
force-pushed
the
generate-lb-country-region-pop-pool-configs
branch
from
13e352d
to
34f760c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the
cloudflare_load_balancergeneration to remap thecountry_pools,region_poolsandpop_poolsto the nested block instead of the object/map field.This was a bit of tricky one to track down because the original response from the API has the correct schema attributes but the kicker is that they are not a supported type (for good reasons!).