Merge pull request #647 from cloudflare/route-errors-to-stderr

generate: route errors to stdout
cloudflare · Dec 14, 2023 · f7fe91a · f7fe91a
2 parents 28f8192 + a3d295a
commit f7fe91a
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 7 deletions.
diff --git a/internal/app/cf-terraforming/cmd/generate.go b/internal/app/cf-terraforming/cmd/generate.go
@@ -1161,12 +1161,12 @@ func generateResources() func(cmd *cobra.Command, args []string) {
 			jsonStructData[0].(map[string]interface{})["id"] = zoneID
 			jsonStructData[0].(map[string]interface{})["cache_type"] = tieredCache.Type.String()
 		default:
-			fmt.Fprintf(cmd.OutOrStdout(), "%q is not yet supported for automatic generation", resourceType)
+			fmt.Fprintf(cmd.OutOrStderr(), "%q is not yet supported for automatic generation", resourceType)
 			return
 		}
 		// If we don't have any resources to generate, just bail out early.
 		if resourceCount == 0 {
-			fmt.Fprint(cmd.OutOrStdout(), "no resources found to generate. Exiting...")
+			fmt.Fprint(cmd.OutOrStderr(), "no resources found to generate")
 			return
 		}
 

diff --git a/internal/app/cf-terraforming/cmd/generate_test.go b/internal/app/cf-terraforming/cmd/generate_test.go
@@ -79,10 +79,8 @@ func TestGenerate_writeAttrLine(t *testing.T) {
 
 func TestGenerate_ResourceNotSupported(t *testing.T) {
 	output, err := executeCommandC(rootCmd, "generate", "--resource-type", "notreal")
-
-	if assert.Nil(t, err) {
-		assert.Contains(t, output, "\"notreal\" is not yet supported for automatic generation")
-	}
+	assert.Nil(t, err)
+	assert.Equal(t, output, `"notreal" is not yet supported for automatic generation`)
 }
 
 func TestResourceGeneration(t *testing.T) {

diff --git a/internal/app/cf-terraforming/cmd/import.go b/internal/app/cf-terraforming/cmd/import.go
@@ -481,7 +481,7 @@ func runImport() func(cmd *cobra.Command, args []string) {
 				log.Fatal(err)
 			}
 		default:
-			fmt.Fprintf(cmd.OutOrStdout(), "%q is not yet supported for state import", resourceType)
+			fmt.Fprintf(cmd.OutOrStderr(), "%q is not yet supported for state import", resourceType)
 			return
 		}