APO-286: Prevent default settings from enabling Auto Minify due to deprecation #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aseure
requested review from
jacobbednarz,
william-woodhead,
cf-ypark and
jeehoon-cf
jacobbednarz
approved these changes
Aug 6, 2024
…precation This commit prevents the Auto Minify setting from being enabled whenever a new user is enabling the default Cloudflare settings for Wordpress. This is following the Auto Minify deprecation whose removal is scheduled for August 5th, 2024. Because the settings endpoint will remain available on Cloudflare API and will eventually be made a no-op, the interface of the users of the previous version of the Wordpress plugin will not see their interface break. The `compiled.js` change, along with the `lang/*` changes were copied after running `yarn build:production` following [this PR of the `cloudflare-plugin-frontend` plugin](cloudflare/cloudflare-plugin-frontend#202).
aseure
added a commit
to aseure/Cloudflare-WordPress
that referenced
this pull request
Aug 7, 2024
**🔖 Summary** This release includes cloudflare#547 which prevent default settings from enabling Auto Minify due to deprecation.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit prevents the Auto Minify setting from being enabled whenever a new user is enabling the default Cloudflare settings for Wordpress.
This is following the Auto Minify deprecation whose removal is scheduled for August 5th, 2024.
Because the settings endpoint will remain available on Cloudflare API and will eventually be made a no-op, the interface of the users of the previous version of the Wordpress plugin will not see their interface break.
The
compiled.jschange, along with thelang/*changes were copied after runningyarn build:productionfollowing this PR of thecloudflare-plugin-frontendplugin.