Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPEED-777: Upgrade cloudflare-plugin-frontend to v3.8.0 (#534) #535

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

aseure
Copy link
Member

@aseure aseure commented Feb 26, 2024

🔖 Summary

By upgrading the compiled files from cloudflare-plugin-frontend as of v3.8.0, this commit aims at removing all Railgun-related code, which is now a deprecated Cloudflare feature. This change is proposed due to a Bad Request banner which is now shown on the Cloudflare Wordpress plugin page because of a failing call to one of the deprecated Railgun endpoints.

Close #534.

**🔖 Summary**

By upgrading the compiled files from `cloudflare-plugin-frontend` as of
v3.8.0, this commit aims at removing all Railgun-related code, which is
now a deprecated Cloudflare feature. This change is proposed due to a
`Bad Request` banner which is now shown on the Cloudflare Wordpress
plugin page because of a failing call to one of the deprecated Railgun
endpoints.

Close cloudflare#534.
@aseure
Copy link
Member Author

aseure commented Feb 26, 2024

@jacobbednarz I've looked at the git history, but couldn't understand how the compiled.js.map is now produced in cloudflare-plugin-frontend. My understanding is that we changed the build tool from gulp to npm and now yarn in cloudflare-plugin-frontend and the gulp compress command is now outdated. If not, could you tell me what's the best way to produce that file. If so, is the compiled.js.map file now outdated and could be removed?

@jacobbednarz
Copy link
Member

jacobbednarz commented Feb 27, 2024

as far as i recall, we just need to update the version use by the JS package manager and that should be enough (yarn upgrade ... type of thing)

@aseure
Copy link
Member Author

aseure commented Feb 27, 2024

@jacobbednarz Thing is, there's no JS package manager configuration in this repository (i.e. no package.json). All I did in the cloudflare-plugin-frontend was to run yarn build:production and copy-paste the resulting compiled.js file in that repository. However, no compiled.js.map got generated, hence my question.

@jacobbednarz
Copy link
Member

works for me! the process i was thinking of is for the backend plugin that i already merged in so disregard that.

if you want to in the future, you can pull the frontend code into this repository and have it build in place to save the confusion.

@aseure aseure merged commit 145e264 into cloudflare:master Mar 4, 2024
5 checks passed
aseure added a commit to aseure/Cloudflare-WordPress that referenced this pull request Mar 4, 2024
**🔖 Summary**

This release includes two minor fixes.

First one is making sure that the only the active zone is fetched when
retrieving the customer zone, preventing accidental fetching of a purged
zone with the same name, which happened to at least one customer.

Second change is about preventing some error banners from appearing on
the user plugin page, which was due to failing calls to retrieve details
about the Railgun settings of the user, which is now deprecated by
Cloudflare, and whose endpoints have been decomissioned.

**🚧 Changes**

- [CUSTESC-36595: Retrieve the Wordpress domain only from the active zone](cloudflare#532)
- [SPEED-777: Upgrade cloudflare-plugin-frontend to v3.8.0](cloudflare#535)
@aseure aseure mentioned this pull request Mar 4, 2024
aseure added a commit to aseure/Cloudflare-WordPress that referenced this pull request Mar 4, 2024
**🔖 Summary**

This commit is a follow-up to cloudflare#535
to include [a minor revert](cloudflare/cloudflare-plugin-frontend#199)
since the current v4.12.5 release seems to have issues due to that code
being wrongly removed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bad Request on Cloudflare Option page
2 participants