-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade dependencies, including http and hyper, where possible. #233
base: main
Are you sure you want to change the base?
Conversation
Breaks docs. Signed-off-by: Omar Zabala-Ferrera <[email protected]>
delegate-attr, base64, snafu, bitflags, hostname, and serde_yaml. Signed-off-by: Omar Zabala-Ferrera <[email protected]>
Signed-off-by: Omar Zabala-Ferrera <[email protected]>
Signed-off-by: Omar Zabala-Ferrera <[email protected]>
Signed-off-by: Omar Zabala-Ferrera <[email protected]>
Signed-off-by: Omar Zabala-Ferrera <[email protected]>
Signed-off-by: Omar Zabala-Ferrera <[email protected]>
Signed-off-by: Omar Zabala-Ferrera <[email protected]>
Signed-off-by: Omar Zabala-Ferrera <[email protected]>
Signed-off-by: Omar Zabala-Ferrera <[email protected]>
@jcrossley3 or @Lazzaretti would you be able to review this? |
I forgot about the example projects and other archs 🤦♂️. I'll work on fixing these. |
Signed-off-by: Omar Zabala-Ferrera <[email protected]>
Signed-off-by: Omar Zabala-Ferrera <[email protected]>
Signed-off-by: Omar Zabala-Ferrera <[email protected]>
Signed-off-by: Omar Zabala-Ferrera <[email protected]>
Signed-off-by: Omar Zabala-Ferrera <[email protected]>
I could use some help with the failing tests. I'm not sure what is causing this error: It happens when running the test: cargo test --target wasm32-wasi --features "http-0-2-binding hyper-0-14 hyper_wasi" But the below works, so I imagine some testing dependency is the issue. cargo build --target wasm32-wasi --features "http-0-2-binding hyper-0-14 hyper_wasi" I'm not really sure if that is indicative of a real error, especially since building the example works: cd example-projects/wasi-example/
cargo build --target wasm32-wasi That being said, running causes an error, but I think it is due to my environment. cd example-projects/wasi-example/
cargo run --target wasm32-wasi
I've not worked with wasm, so any help would be appreciated. |
Description
This PR is the result of the discussion in #227. It upgrades various dependencies, including http and hyper, to the latest versions.
Status
This PR is ready for review. I worked on this sporadically, so I am sure there are better ways to accomplish some of what I did here.
Excluded
warp and actix have not been upgraded to http v1; I found it difficult to convert between types or implement traits. Therefore, those bindings here are mostly unchanged. I also created a separate feature flag for the old http v0.2.
Testing
I ran all the commands on the contributing guide. I also ran
cargo test --all --features
with all the features individually.