Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: 🚀 Created kubeclarity addon terraform code #17

Merged
merged 11 commits into from
Jan 30, 2024
Merged

Feat: 🚀 Created kubeclarity addon terraform code #17

merged 11 commits into from
Jan 30, 2024

Conversation

Tanveer143s
Copy link
Contributor

what

  • Created kubeclarity addon terraform code

@clouddrove-ci clouddrove-ci self-assigned this Jan 29, 2024
@nileshgadgi
Copy link
Member

Add addon path to readme workflow, so that readme for this addon can be automated.
check readme workflow for reference.

@Tanveer143s
Copy link
Contributor Author

Add addon path to readme workflow, so that readme for this addon can be automated. check readme workflow for reference.

Done

@nileshgadgi
Copy link
Member

nileshgadgi commented Jan 29, 2024 •
edited
Loading

Update kubeclarity output in root directory of module as well.

@VishwajitNagulkar
Copy link
Member

Add kubeclarity addon example under _example/complete folder

@nileshgadgi
Copy link
Member

Did you test this by giving true and false to kubeclarity = true argument in example?

@Tanveer143s
Copy link
Contributor Author

Did you test this by giving true and false to kubeclarity = true argument in example?

yes

VishwajitNagulkar
VishwajitNagulkar approved these changes Jan 29, 2024
View reviewed changes
Copy link
Member

@VishwajitNagulkar VishwajitNagulkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clouddrove-ci clouddrove-ci merged commit 8976c0e into master Jan 30, 2024
13 checks passed
@delete-merged-branch delete-merged-branch bot deleted the feat/kubeclarity branch January 30, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VishwajitNagulkar VishwajitNagulkar VishwajitNagulkar approved these changes

@AshutoshAM2002 AshutoshAM2002 Awaiting requested review from AshutoshAM2002

@h1manshu98 h1manshu98 Awaiting requested review from h1manshu98

@anmolnagpal anmolnagpal Awaiting requested review from anmolnagpal anmolnagpal is a code owner

@clouddrove-ci clouddrove-ci Awaiting requested review from clouddrove-ci clouddrove-ci is a code owner

Assignees

@clouddrove-ci clouddrove-ci

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Tanveer143s @nileshgadgi @VishwajitNagulkar @clouddrove-ci