Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Updated attribute 'private_endpoint_network_policies' #39

Merged
merged 5 commits into from
Jul 19, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/auto_assignee.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ on:
workflow_dispatch:
jobs:
assignee:
uses: clouddrove/github-shared-workflows/.github/workflows/[email protected].5
uses: clouddrove/github-shared-workflows/.github/workflows/[email protected].7
secrets:
GITHUB: ${{ secrets.GITHUB }}
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/automerge.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ on:
pull_request:
jobs:
auto-merge:
uses: clouddrove/github-shared-workflows/.github/workflows/[email protected].5
uses: clouddrove/github-shared-workflows/.github/workflows/[email protected].7
secrets:
GITHUB: ${{ secrets.GITHUB }}
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/changelog.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ on:
workflow_dispatch:
jobs:
changelog:
uses: clouddrove/github-shared-workflows/.github/workflows/[email protected].5
uses: clouddrove/github-shared-workflows/.github/workflows/[email protected].7
secrets: inherit
with:
branch: 'master'
8 changes: 4 additions & 4 deletions .github/workflows/tf-checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,21 +6,21 @@ on:
workflow_dispatch:
jobs:
basic-example:
uses: clouddrove/github-shared-workflows/.github/workflows/[email protected].5
uses: clouddrove/github-shared-workflows/.github/workflows/[email protected].7
with:
working_directory: './_example/basic/'

complete-example:
uses: clouddrove/github-shared-workflows/.github/workflows/[email protected].5
uses: clouddrove/github-shared-workflows/.github/workflows/[email protected].7
with:
working_directory: './_example/complete/'

name-specific_subnet:
uses: clouddrove/github-shared-workflows/.github/workflows/[email protected].5
uses: clouddrove/github-shared-workflows/.github/workflows/[email protected].7
with:
working_directory: './_example/name-specific_subnet/'

nat-gateway_subnet:
uses: clouddrove/github-shared-workflows/.github/workflows/[email protected].5
uses: clouddrove/github-shared-workflows/.github/workflows/[email protected].7
with:
working_directory: './_example/nat-gateway_subnet/'
2 changes: 1 addition & 1 deletion .github/workflows/tflint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,6 @@ on:
workflow_dispatch:
jobs:
tf-lint:
uses: clouddrove/github-shared-workflows/.github/workflows/[email protected].5
uses: clouddrove/github-shared-workflows/.github/workflows/[email protected].7
secrets:
GITHUB: ${{ secrets.GITHUB }}
2 changes: 1 addition & 1 deletion .github/workflows/tfsec.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ on:
workflow_dispatch:
jobs:
tfsec:
uses: clouddrove/github-shared-workflows/.github/workflows/[email protected].5
uses: clouddrove/github-shared-workflows/.github/workflows/[email protected].7
secrets: inherit
with:
working_directory: '.'
4 changes: 2 additions & 2 deletions main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ resource "azurerm_subnet" "subnet" {
service_endpoints = var.service_endpoints
service_endpoint_policy_ids = var.service_endpoint_policy_ids
private_link_service_network_policies_enabled = var.subnet_enforce_private_link_service_network_policies
private_endpoint_network_policies_enabled = var.subnet_enforce_private_link_endpoint_network_policies
private_endpoint_network_policies = var.private_endpoint_network_policies

dynamic "delegation" {
for_each = var.delegation
Expand Down Expand Up @@ -95,7 +95,7 @@ resource "azurerm_route_table" "rt" {
name = var.route_table_name == null ? format("%s-route-table", module.labels.id) : format("%s-%s-route-table", module.labels.id, var.route_table_name)
location = var.location
resource_group_name = var.resource_group_name
disable_bgp_route_propagation = var.disable_bgp_route_propagation
bgp_route_propagation_enabled = var.bgp_route_propagation_enabled
tags = module.labels.tags

dynamic "route" {
Expand Down
12 changes: 6 additions & 6 deletions variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -70,10 +70,10 @@ variable "subnet_names" {
description = "A list of public subnets inside the vNet."
}

variable "subnet_enforce_private_link_endpoint_network_policies" {
type = bool
default = false
description = "A map with key (string) `subnet name`, value (bool) `true` or `false` to indicate enable or disable network policies for the private link endpoint on the subnet. Default value is false."
variable "private_endpoint_network_policies" {
type = string
default = "Disabled"
description = "Possible values are Disabled, Enabled, NetworkSecurityGroupEnabled and RouteTableEnabled. Defaults to Disabled.."
}

variable "service_endpoints" {
Expand Down Expand Up @@ -156,9 +156,9 @@ variable "route_table_name" {
description = "The name of the route table."
}

variable "disable_bgp_route_propagation" {
variable "bgp_route_propagation_enabled" {
type = bool
default = false
default = true
description = "Boolean flag which controls propagation of routes learned by BGP on that route table."
}

Expand Down
4 changes: 2 additions & 2 deletions versions.tf
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
# Terraform version
terraform {
required_version = ">= 1.6.6"
required_version = ">= 1.7.8"
}

terraform {
required_providers {
azurerm = {
source = "hashicorp/azurerm"
version = ">=3.85.0"
version = ">=3.112.0"
}
}
}