New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix:update azurerm version #41

Open

vjdbj wants to merge 21 commits into master from fix/version-upgrade

Member

vjdbj commented Sep 11, 2024 •

edited

Loading

what

Added subscription_id for provider in root module
Also updated the modules release version in root modules
Fixed automerge workflow.

why

subscription_id is compulsory to add for terraform planning


          fix:update azurerm version

2bfdcb0

clouddrove-ci self-assigned this

vjdbj added 10 commits

September 12, 2024 01:32


          fix:fixed formatting

6ac5dc3


          fix:fixed tflint warnings

e0cd9c5


          fix:fixed errors due to tflint

90643e1


          fix: updated random provider

562e132


          fix: ran tf fmt

6e469c8


          fix: tflint warnings

2c84383


          fix: removed unused variables

9b1daa9


          fix:fixed tflint errors and removed unused variables

06ad1a4


          fix:fixed automerge workflow

665d708


          fix:fixed yaml syntax error in automerge workflow

fbfd4f0

vjdbj requested review from 13archit and d4kverma

September 12, 2024 21:24


          fix:removed subscription id

68e5a6c

13archit reviewed

View reviewed changes

README.yaml Outdated Show resolved Hide resolved

13archit reviewed

View reviewed changes

README.yaml Outdated Show resolved Hide resolved

13archit reviewed

View reviewed changes

examples/complete/versions.tf Outdated Show resolved Hide resolved

13archit reviewed

View reviewed changes

main.tf Show resolved Hide resolved

13archit reviewed

View reviewed changes

variables.tf Show resolved Hide resolved

13archit reviewed

View reviewed changes

versions.tf Outdated Show resolved Hide resolved


          Added resource for data encryption

2478adf

github-advanced-security bot found potential problems

View reviewed changes

examples/complete/main.tf Fixed Show fixed Hide fixed

Member

clouddrove-ci commented Oct 4, 2024

`Terraform Security Scan` Failed

Show Output


          Fix:Added network_acls in vault

3e5084a

Member

clouddrove-ci commented Oct 4, 2024

`Terraform Security Scan` Failed

Show Output


          Fix:fixed variables

b332a11

Member

clouddrove-ci commented Oct 4, 2024

`Terraform Security Scan` Failed

Show Output

vjdbj and others added 2 commits

October 4, 2024 17:33


          Fix:fixed git repo link in precommit ci

5663a91


          [pre-commit.ci] auto fixes from pre-commit.com hooks

da3a5e2

for more information, see https://pre-commit.ci

Member

clouddrove-ci commented Oct 4, 2024

`Terraform Security Scan` Failed

Show Output

1 similar comment

Member

clouddrove-ci commented Oct 4, 2024

`Terraform Security Scan` Failed

Show Output


          Fix:removed lints

2ce6dbd

Member

clouddrove-ci commented Oct 4, 2024

`Terraform Security Scan` Failed

Show Output


          updated .pre-commit-config file

368d760

Member

clouddrove-ci commented Oct 4, 2024

`Terraform Security Scan` Failed

Show Output


          fix: fixed subscription_id

1a4a752

Member

clouddrove-ci commented Oct 14, 2024

`Terraform Security Scan` Failed

Show Output

13archit reviewed

View reviewed changes

examples/complete/main.tf Outdated

               locals {
-                name        = "app"
-                environment = "test"
+                name        = "lacoster-23"

Member

13archit Oct 16, 2024

Please revert it to app and test

Member Author

vjdbj Oct 16, 2024

done

13archit reviewed

View reviewed changes

examples/complete/main.tf Outdated

+                  azurerm.main_sub = azurerm
+                }
+                name                        = "oliveware-23"

Member

13archit Oct 16, 2024

Please use local here in name and environment.

Member Author

vjdbj Oct 16, 2024

done


          fix:configured name and environment from locals in vault module

66fd2e8

Member

clouddrove-ci commented Oct 16, 2024

`Terraform Security Scan` Failed

Show Output

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet