Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 🚀 Created GitHub OIDC role module #33

Merged
merged 22 commits into from
Mar 5, 2024
Merged

Conversation

Tanveer143s
Copy link
Contributor

what

  • Created github oidc role terraform module

@nileshgadgi
Copy link
Member

nileshgadgi commented Feb 29, 2024

update this PR branch with base branch (master)
pull from master branch

@nileshgadgi
Copy link
Member

Update the example folder name with the official structure.
https://developer.hashicorp.com/terraform/language/modules/develop/structure
from _example to examples

@Tanveer143s
Copy link
Contributor Author

update this PR branch with base branch (master) pull from master branch

Done

@Tanveer143s
Copy link
Contributor Author

Update the example folder name with the official structure. https://developer.hashicorp.com/terraform/language/modules/develop/structure from _example to examples

Done

nileshgadgi
nileshgadgi previously approved these changes Mar 1, 2024
Copy link
Member

@nileshgadgi nileshgadgi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good To Me!

@Tanveer143s Tanveer143s dismissed stale reviews from h1manshu98 and nileshgadgi via 9dcdfd2 March 4, 2024 12:07
Copy link
Member

@VishwajitNagulkar VishwajitNagulkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nileshgadgi
Copy link
Member

  • How is this readme file going to be dynamically updated like the root readme? did you prepared any workflow for this?

@Tanveer143s
Copy link
Contributor Author

  • How is this readme file going to be dynamically updated like the root readme? did you prepared any workflow for this?

no

@nileshgadgi
Copy link
Member

Then it's not going to be updated dynamically, you can update readme workflow for module readme. take reference from addon module.

@Tanveer143s
Copy link
Contributor Author

Then it's not going to be updated dynamically, you can update readme workflow for module readme. take reference from addon module.

we need this module for blog can we do it later in another branch

Copy link
Member

@nileshgadgi nileshgadgi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

modules/aws_github_oidc_role/README.md Show resolved Hide resolved
@clouddrove-ci clouddrove-ci enabled auto-merge (squash) March 5, 2024 16:17
@clouddrove-ci clouddrove-ci merged commit f1b4e86 into master Mar 5, 2024
15 checks passed
@clouddrove-ci clouddrove-ci deleted the feat/oidc-role branch March 5, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants