Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Blueprints, 02-at-scale]: Integration of Hashicorp Vault #181

Merged
merged 13 commits into from
Jul 24, 2024
Merged

Conversation

carlosrodlop
Copy link
Collaborator

No description provided.

@carlosrodlop carlosrodlop added the enhancement New feature or request label Jul 24, 2024
@carlosrodlop carlosrodlop requested a review from a team as a code owner July 24, 2024 11:55
@ps-ssingh ps-ssingh self-requested a review July 24, 2024 12:02
# https://github.com/hashicorp/terraform-aws-hashicorp-vault-eks-addon?tab=readme-ov-file#usage
## Init vault
kubectl exec -it vault-0 -n "$vault_ns" -- vault operator init | tee "$HERE/vault-init.log" || echo "Vault already initialized"
## Useal the vault
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about an input validation to check ensure unseal keys are not empty ?

Copy link
Collaborator

@ps-ssingh ps-ssingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!

@carlosrodlop carlosrodlop merged commit 531531f into develop Jul 24, 2024
10 checks passed
@carlosrodlop carlosrodlop deleted the vault branch July 24, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants