Skip to content

Commit

Permalink
Merge pull request #33 from sboardwell/add-tags-to-all-ebs-volumes
Browse files Browse the repository at this point in the history
Ensure any PVC includes the custom tags
  • Loading branch information
carlosrodlop committed Dec 21, 2023
2 parents 03e523d + 6e6f3c9 commit c56349a
Show file tree
Hide file tree
Showing 6 changed files with 23 additions and 7 deletions.
2 changes: 1 addition & 1 deletion .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
* @carlosrodlop
* @ryecarrigan
* @sboardwell
* @sboardwell
6 changes: 3 additions & 3 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ crash.log
crash.*.log

# Exclude all .tfvars files, which are likely to contain sensitive data, such as
# password, private keys, and other secrets. These should not be part of version
# control as they are data points which are potentially sensitive and subject
# password, private keys, and other secrets. These should not be part of version
# control as they are data points which are potentially sensitive and subject
# to change depending on the environment.
*.tfvars
*.tfvars.json
Expand Down Expand Up @@ -39,4 +39,4 @@ terraform.rc
# Assests created via Blueprints
*.log
.deployed
kubeconfig*.yaml
kubeconfig*.yaml
2 changes: 1 addition & 1 deletion .terraform-docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,4 +37,4 @@ sections:
- outputs

# see https://terraform-docs.io/user-guide/configuration/version/
version: ">= 0.16.0, < 1.0.0"
version: ">= 0.16.0, < 1.0.0"
8 changes: 8 additions & 0 deletions blueprints/01-getting-started/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,14 @@ module "eks_blueprints_addons" {
eks_addons = {
aws-ebs-csi-driver = {
service_account_role_arn = module.ebs_csi_driver_irsa.iam_role_arn
# ensure any PVC created also includes the custom tags
configuration_values = jsonencode(
{
controller = {
extraVolumeTags = local.tags
}
}
)
}
coredns = {}
vpc-cni = {}
Expand Down
8 changes: 8 additions & 0 deletions blueprints/02-at-scale/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,14 @@ module "eks_blueprints_addons" {
eks_addons = {
aws-ebs-csi-driver = {
service_account_role_arn = module.ebs_csi_driver_irsa.iam_role_arn
# ensure any PVC created also includes the custom tags
configuration_values = jsonencode(
{
controller = {
extraVolumeTags = local.tags
}
}
)
}
coredns = {}
vpc-cni = {}
Expand Down
4 changes: 2 additions & 2 deletions values.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@ OperationsCenter:
FirstName: ${LicFirstName}
LastName: ${LicLastName}
Email: ${LicEmail}
Company: ${LicCompany}
Company: ${LicCompany}
Master:
JavaOpts: >-
-XX:InitialRAMPercentage=70.0
-XX:MaxRAMPercentage=70.0
-XX:MaxRAMPercentage=70.0

0 comments on commit c56349a

Please sign in to comment.