updates according to comments from Carlos. #20
Conversation
|
@holywen can we reiview this together next week. Is it actually running like this? |
|
Sure, I did some tests and verified that the service pods are running on the correct nodes. |
|
@holywen, @ps-ssingh can you validate why is not running GHA when you do a PR? |
|
GOOD Progress! Once you amend my comments we are a good to merge this PR |
|
In the Main README page at entry level here https://github.com/cloudbees/terraform-aws-cloudbees-cd-eks-addon/blob/main/README.md we need to tell that by default the product use the Server License type. In the Getting started blueprint we don't need to mention nothing more because it uses the same lincense (Server) but for At scale it requires a Enterprise type of license |
udpate license information
|
License information udpated in both README.md files. |
| @@ -15,6 +15,9 @@ Once you have familiarized yourself with the [Getting Started blueprint](../01-g | |||
| > [!TIP] | |||
| > A [Resource Group](https://docs.aws.amazon.com/ARG/latest/userguide/resource-groups.html) is added to get a full list with all resources created by this blueprint. | |||
|
|
|||
| ## CD License | |||
| A initial license is required to use CloudBees CD. Please refer to the [CloudBees CD Licensing](https://docs.cloudbees.com/docs/cloudbees-cd/latest/set-up-cdro/licenses) for more information. | |||
There was a problem hiding this comment.
Here you need a Enterprise License
There was a problem hiding this comment.
blueprints/02-at-scale/main.tf
Outdated
| } | ||
| } | ||
|
|
||
| resource "aws_iam_role" "managed_ng" { |
There was a problem hiding this comment.
You don't need this because they are the defaults permissions. The reason about creating this resource is in case you need extra permission like s3...
blueprints/02-at-scale/main.tf
Outdated
| tags = var.tags | ||
| } | ||
|
|
||
| resource "aws_iam_instance_profile" "managed_ng" { |
There was a problem hiding this comment.
This also can be deleted as commented above
blueprints/02-at-scale/main.tf
Outdated
| desired_size = 1 | ||
| taints = [local.mng["cbcd_apps"]["taints"]] | ||
| labels = local.mng["cbcd_apps"]["labels"] | ||
| create_iam_role = false |
There was a problem hiding this comment.
| create_iam_role = false | |
blueprints/02-at-scale/main.tf
Outdated
| taints = [local.mng["cbcd_apps"]["taints"]] | ||
| labels = local.mng["cbcd_apps"]["labels"] | ||
| create_iam_role = false | ||
| iam_role_arn = aws_iam_role.managed_ng.arn |
There was a problem hiding this comment.
| iam_role_arn = aws_iam_role.managed_ng.arn | |
There was a problem hiding this comment.
delete this too. As I mentioned below it will use default permissions
No description provided.