Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lavinmqctl cluster status #787

Merged
merged 3 commits into from
Sep 19, 2024
Merged

Lavinmqctl cluster status #787

merged 3 commits into from
Sep 19, 2024

Conversation

viktorerlingsson
Copy link
Member

WHAT is this pull request doing?

Adds the cluster_status cmd to lavinmqctl, which shows information about the running cluster.

HOW can this pull request be tested?

Run lavinmqctl cluster_status

Copy link
Member

@snichme snichme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

One thing (probably outside the scope of this PR) have we talked about keeping the output from the ctl stable? If something starts scripting with the ctl they probably want the same output even if they get a new version.
This is hard (and I dont think we should commit to that) but if we don't do it maybe add support for outputing to different formats like json as well

@viktorerlingsson
Copy link
Member Author

One thing (probably outside the scope of this PR) have we talked about keeping the output from the ctl stable? If something starts scripting with the ctl they probably want the same output even if they get a new version. This is hard (and I dont think we should commit to that) but if we don't do it maybe add support for outputing to different formats like json as well

I don't remember us talking about that, but I think it's a good idea to support at least json output as well!

@viktorerlingsson viktorerlingsson merged commit c92656c into main Sep 19, 2024
23 of 25 checks passed
@viktorerlingsson viktorerlingsson deleted the lavinmqctl_cluster_status branch September 19, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants