Dont log handled exception as error with backtrace #776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spuun
requested review from
carlhoerberg,
kickster97,
snichme and
viktorerlingsson
as code owners
|
Note that this won't take fully effect until we've released a new version of amqp-client.cr. |
viktorerlingsson
approved these changes
Sep 13, 2024
snichme
approved these changes
Sep 13, 2024
kickster97
approved these changes
Sep 16, 2024
spuun
force-pushed
the
shovels-less-noisy-logging
branch
from
56b2a00
to
9e6d749
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT is this pull request doing?
This will change log level and remove backtrace when we log errors in the shovel. Since the errors are handled and the shovel should reconnect warn should be enough.
This PR needs cloudamqp/amqp-client.cr#47 to get rid of all scary logging.
HOW can this pull request be tested?
Run a shovel and close the connection from mgmt ui.