feat : add Lifecycle to AppSpec #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tae2089
reviewed
May 17, 2024
Comment on lines
+17
to
+23
| lifecycle: | ||
| postStart: | ||
| exec: | ||
| command: ["/bin/sh", "-c", "echo Hello from the postStart handler > /usr/share/message"] | ||
| preStop: | ||
| exec: | ||
| command: ["/bin/sh","-c","nginx -s quit; while killall -0 nginx; do sleep 1; done"] |
There was a problem hiding this comment.
lifecycle 추가 안하고 돌렸을때는 문제 없이 돌아가나요?
There was a problem hiding this comment.
AppSpec에 추가된 상태에서 위 lifecycle에 명시된 내용이 없는 경우를 말씀하시는 걸까요?
There was a problem hiding this comment.
make install의 경우 지우고 실행해도 이전 yaml로 돌아가는 것 같아보이네요 😢
그런데 kubectl apply -f config/samples/app_v1alpha1_application.yaml로 실행하면 명시된 필드가 비어있다고 실행되지 않습니다.
tae2089
approved these changes
May 28, 2024
api/v1alpha1/application_types.go
Outdated
| @@ -31,6 +31,7 @@ type AppSpec struct { | |||
| AppType string `json:"appType,omitempty"` // back, front-spa, front-srr | |||
| Annotations map[string]string `json:"annotations,omitempty"` | |||
| ContainerName string `json:"containerName"` | |||
| LifeCycle *v1.Lifecycle `json:"lifeCycle"` | |||
There was a problem hiding this comment.
Suggested change
| LifeCycle *v1.Lifecycle `json:"lifeCycle"` | |
| // +optional | |
| LifeCycle *v1.Lifecycle `json:"lifeCycle,omitempty"` |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업내역
✅ : AppSpec에 라이프사이클 관련 구조체 추가
✅ : UpsertDeployment에 Appspec의 추가된 내용 반영 코드 작성
추가된 내용
// +optional추가