Adding SSHKEY Repository as a parameter to scale-ci-baseline #73
Conversation
piyushgupta1551
changed the title
|
@piyushgupta1551 do you want to add a comment in the commit "Fixes issue #72 " to reference the related issue |
| export PBENCH_SSH_PRIVATE_KEY_FILE=${WORKSPACE}/perf-dept/ssh_keys/id_rsa_perf | ||
| chmod 600 ${PRIVATE_KEY} | ||
| git clone https://${SSHKEY_TOKEN}@${SSHKEY_REPO} | ||
| if [ -f ${WORKSPACE}/${SSHKEY_REPOPATH_PUB} ] && [ -f ${WORKSPACE}/${SSHKEY_REPOPATH_PRIV} ] |
There was a problem hiding this comment.
We need to update other jobs to do the same as they use the same logic to fetch the ssh keys.
There was a problem hiding this comment.
This can be tackled in a separate PR I guess.
| @@ -137,6 +140,19 @@ | |||
| description: 'Duration to run' | |||
| name: BASELINE_WORKLOAD_DURATION | |||
| trim: 'false' | |||
| - string: | |||
There was a problem hiding this comment.
This change will work when we are calling the individual job, the following minor changes are needed to get it working with the pipeline: the pipeline/build scripts read the properties file/config with the parameters and call the jobs. so the sample properties file ( https://github.com/openshift-scale/scale-ci-pipeline/blob/master/properties-files/baseline.properties ) and build script needs to be updated with the new parameters ( https://github.com/openshift-scale/scale-ci-pipeline/blob/master/pipeline-scripts/baseline.groovy#L46 ).
There was a problem hiding this comment.
makes sense @chaitanyaenr . I was looking at updating the individual tests as I'm not wanting to run them all. Would it be okay if I update the yaml, properties and groovy files for each test at a time and raise a pull request?
There was a problem hiding this comment.
@chaitanyaenr - could you please review the most recent changes in this request?
…. Fixes issue cloud-bulldozer#72 updated description. Fixes issue cloud-bulldozer#72
Non-breaking change to parameterize the SSKHEY repo with redhat-perf as default as suggested.