Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding vegeta-wrapper dashboard to grafonnet #108

Merged
merged 3 commits into from
Feb 9, 2024

Conversation

smanda99
Copy link
Collaborator

Type of change

  • Refactor
  • New feature
  • Bug fix
  • Optimization
  • Documentation Update

Description

Adding vegeta-wrapper dashboard to grafonnet

Related Tickets & Documents

  • Related Issue #
  • Closes #

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please describe the System Under Test.
  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

@smanda99 smanda99 added the enhancement New feature or request label Jan 31, 2024
@smanda99 smanda99 self-assigned this Jan 31, 2024
Copy link
Collaborator

@vishnuchalla vishnuchalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting a link to the previous and current dashboards to make sure they are exactly the same look and feel wise.

@vishnuchalla
Copy link
Collaborator

@vishnuchalla

old dashboard: http://dittybopper-dittybopper.apps.smanda-ocp1.perfscale.devcluster.openshift.com/d/jNFApWhSz/vegeta-results-dashboard?orgId=1

new dashboard: http://dittybopper-dittybopper.apps.smanda-ocp1.perfscale.devcluster.openshift.com/d/c6KApZhIk/vegeta-results?orgId=1

Hosting these dashboards on your own cluster is not useful when they have elasticsearch as data source. Can you use your dev grafana instance instead to host them for testing and PR review purposes please?

Copy link
Collaborator

@vishnuchalla vishnuchalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vishnuchalla vishnuchalla merged commit 1ab1846 into cloud-bulldozer:master Feb 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants