Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding OVN Monitoring Dashboard to grafonnet #105

Merged
merged 7 commits into from
Feb 8, 2024
Merged

Adding OVN Monitoring Dashboard to grafonnet #105

merged 7 commits into from
Feb 8, 2024

Conversation

smanda99
Copy link
Collaborator

@smanda99 smanda99 commented Jan 4, 2024

Type of change

  • Refactor
  • New feature
  • Bug fix
  • Optimization
  • Documentation Update

Description

Adding OVN Monitoring Dashboard to grafonnet.

Related Tickets & Documents

  • Related Issue #
  • Closes #

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please describe the System Under Test.
  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

@smanda99 smanda99 self-assigned this Jan 4, 2024
@smanda99 smanda99 added the enhancement New feature or request label Jan 4, 2024
vishnuchalla
vishnuchalla requested changes Feb 1, 2024
View reviewed changes
Copy link
Collaborator

@vishnuchalla vishnuchalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting a link to the previous and current dashboards to make sure they are exactly the same look and feel wise.

vishnuchalla
vishnuchalla reviewed Feb 1, 2024
View reviewed changes
Untitled Diagram.drawio Outdated
@@ -0,0 +1,52 @@
<mxfile host="app.diagrams.net" modified="2024-01-10T12:59:57.585Z" agent="Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/120.0.0.0 Safari/537.36" etag="uBdf2yN_Z3OYIy3vkvF_" version="22.1.18" type="github">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need a draw.io file here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry i will remove this file. it is not needed.

@smanda99
Copy link
Collaborator Author

smanda99 commented Feb 7, 2024

old dashboard: http://dittybopper-dittybopper.apps.smanda-ocp1.perfscale.devcluster.openshift.com/d/68FAtWhSz/ovn-monitoring?orgId=1

new dashboard: http://dittybopper-dittybopper.apps.smanda-ocp1.perfscale.devcluster.openshift.com/d/p7OApW2Sk/ovn-monitoring-dashboard?orgId=1

vishnuchalla
vishnuchalla approved these changes Feb 8, 2024
View reviewed changes
Copy link
Collaborator

@vishnuchalla vishnuchalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vishnuchalla vishnuchalla merged commit c6ee432 into cloud-bulldozer:master Feb 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vishnuchalla vishnuchalla vishnuchalla approved these changes

@jtaleric jtaleric Awaiting requested review from jtaleric

@rsevilla87 rsevilla87 Awaiting requested review from rsevilla87

@krishvoor krishvoor Awaiting requested review from krishvoor

Assignees

@smanda99 smanda99

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smanda99 @vishnuchalla