Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix concurrent map writes panic #47

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Fix concurrent map writes panic #47

merged 1 commit into from
Oct 17, 2023

Conversation

rsevilla87
Copy link
Member

@rsevilla87 rsevilla87 commented Oct 17, 2023 •
edited
Loading

Type of change

  • Refactor
  • New feature
  • Bug fix
  • Optimization
  • Documentation Update

Description

Fixing concurrent map writes panic that happens occasionally because we're reusing the same Tool instance for all goroutines.

Related Tickets & Documents

  • Related Issue #
  • Closes #

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please describe the System Under Test.
  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

@rsevilla87 rsevilla87 added the bug Something isn't working label Oct 17, 2023
@rsevilla87 rsevilla87 merged commit 5776cd4 into cloud-bulldozer:main Oct 17, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rsevilla87