Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows users to print version #22

Merged
merged 6 commits into from
Jul 24, 2023

Conversation

krishvoor
Copy link
Member

@krishvoor krishvoor commented Jul 20, 2023

Allows users to print ingress-perf version
Indexes the ingress-perf version into grafana reporting

Type of change

  • Refactor
  • New feature
  • Bug fix
  • Optimization
  • Documentation Update

Description

Allows users to print ingress-perf version

 krvoora ~./bin/ingress-perf version
😎 Ingress version is v0.2.4:fe336dd
 krvoora ~

Related Tickets & Documents

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please describe the System Under Test.
  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

Allows users to prin ingress-perf version

Signed-off-by: Krishna Harsha Voora <[email protected]>
@rsevilla87 rsevilla87 self-requested a review July 20, 2023 10:00
Copy link
Member

@rsevilla87 rsevilla87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking over @krishvoor , added some somments.

cmd/ingress-perf.go Outdated Show resolved Hide resolved
Comment on lines 38 to 39
Run: func(cmd *cobra.Command, args []string) {
fmt.Printf("%s@%s \n", version.Version, version.GitCommit)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would print as requested in the RFE

./bin/ingress-perf version
version-branch@0a412d04ae6690d95eec2b5aa740c794ae08b8f6 

or would you like this to be printed like in the kube-burner?

kube-burner version
Version: 1.5
Git Commit: db331979da3447c210ce308a4c1d5e473ba7d440
Build Date: 2023-04-05T17:02:00Z
Go Version: go1.19.7
OS/Arch: darwin arm64

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rsevilla87 can you ptal?

cmd/ingress-perf.go Outdated Show resolved Hide resolved
Signed-off-by: Krishna Harsha Voora <[email protected]>
Makefile Outdated Show resolved Hide resolved
@rsevilla87
Copy link
Member

rsevilla87 commented Jul 24, 2023

@krishvoor , thoughts on indexing the ingress-perf version number as well? you should be able to add it to the Result struct

type Result struct {
UUID string `json:"uuid"`
Sample int `json:"sample"`
Config config.Config `json:"config"`
Pods []PodResult `json:"pods"`
Timestamp time.Time `json:"timestamp"`
TotalAvgRps float64 `json:"total_avg_rps"`
StdevRps float64 `json:"rps_stdev"`
StdevLatency float64 `json:"stdev_lat"`
AvgLatency float64 `json:"avg_lat_us"`
MaxLatency float64 `json:"max_lat_us"`
P90Latency float64 `json:"p90_lat_us"`
P95Latency float64 `json:"p95_lat_us"`
P99Latency float64 `json:"p99_lat_us"`
HTTPErrors int64 `json:"http_errors"`
ReadErrors int64 `json:"read_errors"`
WriteErrors int64 `json:"write_errors"`
Requests int64 `json:"requests"`
Timeouts int64 `json:"timeouts"`
ocpmetadata.ClusterMetadata
}

@krishvoor
Copy link
Member Author

@krishvoor , thoughts on indexing the ingress-perf version number as well? you should be able to add it to the Result struct

Yes, this would be useful in grafana reporting.
Update the code, ptal

@rsevilla87 rsevilla87 self-requested a review July 24, 2023 13:57
Copy link
Member

@rsevilla87 rsevilla87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@rsevilla87 rsevilla87 merged commit 51430a1 into cloud-bulldozer:main Jul 24, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFE] Version subcommand
2 participants