Improve log message on deployment reconciliation (#48)

Signed-off-by: Raul Sevilla <[email protected]>
cloud-bulldozer · Oct 23, 2023 · 1c6f35e · 1c6f35e
1 parent 33e3744
commit 1c6f35e
Showing 1 changed file with 9 additions and 2 deletions.
diff --git a/pkg/runner/runner.go b/pkg/runner/runner.go
@@ -242,16 +242,23 @@ func reconcileNs(cfg config.Config) error {
 }
 
 func waitForDeployment(ns, deployment string, maxWaitTimeout time.Duration) error {
-	return wait.PollUntilContextTimeout(context.TODO(), time.Second, maxWaitTimeout, true, func(ctx context.Context) (bool, error) {
+	var errMsg string
+	log.Infof("Waiting for replicas from deployment %s in ns %s to be ready", deployment, ns)
+	err := wait.PollUntilContextTimeout(context.TODO(), time.Second, maxWaitTimeout, true, func(ctx context.Context) (bool, error) {
 		dep, err := clientSet.AppsV1().Deployments(ns).Get(context.TODO(), deployment, metav1.GetOptions{})
 		if err != nil {
 			return false, err
 		}
 		if *dep.Spec.Replicas != dep.Status.ReadyReplicas || *dep.Spec.Replicas != dep.Status.AvailableReplicas {
-			log.Debugf("Waiting for replicas from deployment %s in ns %s to be ready", deployment, ns)
+			errMsg = fmt.Sprintf("%d/%d replicas ready", dep.Status.AvailableReplicas, *dep.Spec.Replicas)
+			log.Debug(errMsg)
 			return false, nil
 		}
 		log.Debugf("%d replicas from deployment %s ready", dep.Status.UpdatedReplicas, deployment)
 		return true, nil
 	})
+	if err != nil && errMsg != "" {
+		log.Error(errMsg)
+	}
+	return err
 }