Use Prometheus bearer token only when provided #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #39 +/- ##
==========================================
+ Coverage 83.33% 83.43% +0.10%
==========================================
Files 6 6
Lines 312 314 +2
==========================================
+ Hits 260 262 +2
Misses 38 38
Partials 14 14 ☔ View full report in Codecov by Sentry. |
jtaleric
approved these changes
Nov 30, 2023
vishnuchalla
approved these changes
Nov 30, 2023
|
Wow, this was super fast 🤯 Will this land in kube-burner soon as well? |
Yeah, I'll cut a hotfix release with this patch today, I'll ping you when ready |
7 tasks
|
Hey @diversario , checkout kube-burner v1.8.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
This library is used in
kube-burner.kube-burner'sinitcommand acceptsusername,passwordandtokenparameters for connecting to Prometheus. However, it is not possible to connect to Prometheus that is configured with username/password only because this library unconditionally sets theBearerheader, including with an emptytoken. This results in a 401 from the Prometheus client.Related Tickets & Documents
Checklist before requesting a review
Testing
I tested this by building
kube-burnerwith the proposed changes and seeing it successfully connect to my basic auth Prometheus.