K8s metadata #38
Merged
K8s metadata #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Raul Sevilla <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #38 +/- ##
=======================================
Coverage 83.33% 83.33%
=======================================
Files 6 6
Lines 312 312
=======================================
Hits 260 260
Misses 38 38
Partials 14 14 ☔ View full report in Codecov by Sentry. |
7 tasks
…en marshalling JSON Signed-off-by: Raul Sevilla <[email protected]>
rsevilla87
force-pushed
the
k8s-metadata
branch
from
d9a5afb
to
7840ef7
Compare
7 tasks
vishnuchalla
reviewed
Dec 5, 2023
| metadata.ClusterType = v.Value | ||
| } | ||
| } | ||
| metadata.SDNType, err = meta.getSDNInfo() |
There was a problem hiding this comment.
Do we need SDNType as well to be populated only when there are infra nodes present?
There was a problem hiding this comment.
infra does not refer to infra nodes but to the "infrastructure" object, which is only present in OpenShift clusters, same as config.openshift.io/v1/networks. for that reason when the infra object is not present, we don't try to get the sdnType
There was a problem hiding this comment.
Yeah, I made this mistake too @vishnuchalla
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Some updates required to make this library compatible with vanilla k8s
infrastructureor theclusterversionresources are not found, assume that this is not an OCP cluster and return empty fields rather than crashingRelated Tickets & Documents
Checklist before requesting a review
Testing