Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding go unit tests to the workflow #19

Closed
wants to merge 1 commit into from
Closed

adding go unit tests to the workflow #19

wants to merge 1 commit into from

Conversation

vishnuchalla
Copy link
Collaborator

@vishnuchalla vishnuchalla commented Jul 6, 2023

Type of change

  • Refactor
  • New feature
  • Bug fix
  • Optimization
  • Documentation Update

Description

Related Tickets & Documents

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

Testing

Tested through the CI

@vishnuchalla
Copy link
Collaborator Author

@shashank-boyapally indexers tests seems to be flaky. Requesting to take a look. Thank you

@shashank-boyapally
Copy link
Collaborator

The reason this has happened is as we randomized the tests(all in context of local.go), sometimes Index() is being called before new() which is seldom in a real world situation, but in order to mitigate this problem I've taken care of creating the placeholder dir whenever Index is being called by which this unexpected error can be avoided. Please look into the changes, Thank you.

Copy link
Member

@chentex chentex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see all the code good, the only thing I see weird is that merge to main commit that you have, fae7f3727b332f27e72aeb44ef6d53604846845e, maybe you need to rebase your working branch.

@vishnuchalla vishnuchalla closed this by deleting the head repository Jul 7, 2023
@vishnuchalla
Copy link
Collaborator Author

I see all the code good, the only thing I see weird is that merge to main commit that you have, fae7f3727b332f27e72aeb44ef6d53604846845e, maybe you need to rebase your working branch.

I tried rebasing but there seems to be having lot many conflicts. So opened up a new one: #20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants