Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove return that prevents multiple queries from a single config #73

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

afcollins
Copy link
Member

Type of change

  • Refactor
  • New feature
  • Bug fix
  • Optimization
  • Documentation Update

Description

If I create touchstone config with multiple "timeseries" queries (i.e. "compute_map") under a single index, this return statement only runs the first timeseries, then aborts from the for loop.

Related Tickets & Documents

None.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

Testing

Run against search dev instance.

Here is an example config:

{
  "elasticsearch": {
    "ripsaw-kube-burner": [
      {
        "filter": {
          "metricName.keyword": "cgroupCPUSeconds-namespaces"
        },
        "timeseries": true
      },
      {
        "filter": {
          "metricName.keyword": "cgroupCPUSeconds-namespaces-start"
        },
        "timeseries": true
      }
    ]
  }
}

Here is a script to run it:

$ cat collect_seconds.sh 
#!/bin/bash

UUIDS="2b7c7289-9a8c-404d-a667-59bb213e63a7"
ES_URL="https://search-perfscale-dev-...amazonaws.com:443"

OUTPUT_FILE="cpu_seconds.json"
CONFIG="config/cpu_seconds.json"
touchstone_compare -vv --config $CONFIG -u $UUIDS -url $ES_URL -o json > $OUTPUT_FILE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant