fix(mvc.View): set style via options (#2705)

clientIO · Jul 11, 2024 · db07082 · db07082
1 parent 7746050
commit db07082
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 1 deletion.
diff --git a/packages/joint-core/src/mvc/ViewBase.mjs b/packages/joint-core/src/mvc/ViewBase.mjs
@@ -35,7 +35,8 @@ export var ViewBase = function(options) {
 var delegateEventSplitter = /^(\S+)\s*(.*)$/;
 
 // List of view options to be set as properties.
-var viewOptions = ['model', 'collection', 'el', 'id', 'attributes', 'className', 'tagName', 'events'];
+// TODO: `style` attribute is not supported in ViewBase class yet, but only in View class that extends ViewBase.
+var viewOptions = ['model', 'collection', 'el', 'id', 'attributes', 'className', 'tagName', 'events', 'style'];
 
 // Set up all inheritable **ViewBase** properties and methods.
 assign(ViewBase.prototype, Events, {

diff --git a/packages/joint-core/test/jointjs/mvc.view.js b/packages/joint-core/test/jointjs/mvc.view.js
@@ -266,4 +266,23 @@ QUnit.module('joint.mvc.View', function(hooks) {
             view.remove();
         });
     });
+
+    QUnit.module('style', function() {
+
+        QUnit.test('as class property', function(assert) {
+            assert.expect(1);
+            var View = joint.mvc.View.extend({
+                style: {
+                    'color': 'red'
+                }
+            });
+            assert.strictEqual(new View().el.style.color, 'red');
+        });
+
+        QUnit.test('as option', function(assert) {
+            assert.expect(1);
+            var View = joint.mvc.View.extend();
+            assert.strictEqual(new View({ style: { 'color': 'red' }}).el.style.color, 'red');
+        });
+    });
 });