Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google.spreadsheets.NewRow (minor update) #182

Draft
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

sayam-nasir
Copy link
Contributor

No description provided.

@sayam-nasir sayam-nasir changed the title NewRow Update Suggestions Google.Spreadsheets-NewRow Trigger - Improvement Suggestions Sep 13, 2024
@DavidDurman DavidDurman changed the title Google.Spreadsheets-NewRow Trigger - Improvement Suggestions google.spreadsheets.NewRow (minor update) Sep 27, 2024
@vtalas
Copy link
Contributor

vtalas commented Oct 15, 2024

this looks promising! here are few notes:

  • initialization of the "index column" should be done in the start method. See here where we get the page token first.

  • the change as it is right now is a breaking change - there is a new required field

  • there is an issue when you add a blank row in between - it detect the last row as a new (highlighted Slovakia)
    image

@vtalas vtalas marked this pull request as draft October 15, 2024 16:24
@vtalas
Copy link
Contributor

vtalas commented Oct 15, 2024

It's a significant improvement; however, there are still some limitations and edge cases. Tracking new rows is not an easy task. Perhaps we can define an explicit ruleset for when NewRow functions properly. These rules will be included in the component description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants