zendesk.tickets (major update), zendesk.chats (removed) #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jirihofman
approved these changes
Sep 13, 2024
DavidDurman
force-pushed
the
zendesktickets-upgrade
branch
from
d520e6a
to
8a3e42e
Compare
jirihofman
requested changes
Sep 25, 2024
There was a problem hiding this comment.
We don't use package-lock.json files yet. Please remove it.
DavidDurman
force-pushed
the
zendesktickets-upgrade
branch
from
53b22a0
to
181353b
Compare
DavidDurman
changed the title
DavidDurman
changed the title
DavidDurman
force-pushed
the
zendesktickets-upgrade
branch
from
181353b
to
ac1cb4e
Compare
DavidDurman
changed the title
jirihofman
approved these changes
Oct 1, 2024
vtalas
reviewed
Oct 4, 2024
There was a problem hiding this comment.
@DavidDurman quotas are missing, there should be at least some quotas set
|
The rate limits of Zendesk are very complicated and also depend on the account tier. I'm not sure how this can be implemented using our current quotas mechanism. See https://developer.zendesk.com/api-reference/introduction/rate-limits/#zendesk-suite-plan-limits |
|
… fields including attachments
…Ticket, FindTicketcoments, UpdateTicket, CreateUser, UpdateUser
…hats that was obsolete and unfinished
DavidDurman
force-pushed
the
zendesktickets-upgrade
branch
from
ac1cb4e
to
f5b4b0f
Compare
vtalas
requested changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Q: It's been under heavy discussions whether to move this connector under the
zendesk/directory or leave it as is inzendesktickets/.This PR also updates the
zendesk.chatsconnector and fixes https://github.com/clientIO/appmixer-components/issues/1873