create new func to avoid the bug on issue #61 #63
+54
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BagToad
reviewed
Sep 25, 2024
BagToad
reviewed
Sep 25, 2024
BagToad
reviewed
Sep 25, 2024
BagToad
reviewed
Sep 25, 2024
BagToad
reviewed
Sep 25, 2024
| if err != nil { | ||
| return nil, fmt.Errorf("error parsing the hostname '%s': %w", host, err) | ||
| } | ||
| oa.Host = host |
There was a problem hiding this comment.
@mouismail We weren't doing this before, can you explain the benefits of doing this now?
There was a problem hiding this comment.
I believe the reason behind this was to handle various OAuth hosts, not just GHEC and
ensures that the oa.Host is dynamically assigned if it is not already set.
There was a problem hiding this comment.
I think this makes sense to me. @jtmcg anything to add?
BagToad
reviewed
Sep 25, 2024
BagToad
requested changes
Sep 25, 2024
There was a problem hiding this comment.
👋 Hey @mouismail. Sorry for the delays getting to this. We reviewed this and added some comments and suggestions. Let us know if we can help with anything!
Co-authored-by: Kynan Ware <[email protected]>
Co-authored-by: Kynan Ware <[email protected]>
Co-authored-by: Kynan Ware <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request primarily focuses on improving error handling and code readability in the OAuth flow. The changes include the introduction of a new function
NewGitHubHostinoauth.goto parse the host URL and return an error if parsing fails. This function is then used in the filesexamples_test.go,oauth_device.go, andoauth_webapp.goto replace the previous method of creating a new host, improving error handling in the process.Fixes: #62
Fixes: cli/cli#9248