This repository has been archived by the owner on May 6, 2020. It is now read-only.
scripts: Add agent version to collect script #1057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make more variables local in the collect script. Signed-off-by: James O. D. Hunt <[email protected]>
Drop support for the `help` and `version` sub-commands in favour of their CLI options only. Signed-off-by: James O. D. Hunt <[email protected]>
Switch to using the `getopt(1)` command for argument parsing as it supports short and long options. Signed-off-by: James O. D. Hunt <[email protected]>
|
This will "work", but won't actually show the correct agent version until we get a new image release containing clearcontainers/agent#213 (commit clearcontainers/agent@14c4a2d). Tested with Kata too (run as Agentversion: |
Add the agent version to the collect script output. Fixes clearcontainers#1055. Signed-off-by: James O. D. Hunt <[email protected]>
Add a `--debug` option to the data collection script that could be useful in the case where the agent version cannot be established. Signed-off-by: James O. D. Hunt <[email protected]>
jodh-intel
force-pushed
the
collect-script-show-agent-version
branch
from
692cb40
to
17ad8f6
Compare
sboeuf
approved these changes
Mar 9, 2018
|
Thanks @jodh-intel for this PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the agent version to the collect script output.
Fixes #1055.
Signed-off-by: James O. D. Hunt [email protected]