-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gemspec needed #24
base: master
Are you sure you want to change the base?
Gemspec needed #24
Conversation
Second comparison of this method in awesome_print/formatter.rb causes the crash. Without this fix, pry + awesome_print cannot be used, as even a simple case such as [1, 2, 3].to_scale will crash # Catch all method to format an arbitrary object. #------------------------------------------------------------------------------ def awesome_self(object, type) if @options[:raw] && object.instance_variables.any? awesome_object(object) elsif object == ENV awesome_hash(object.to_hash) else colorize(object.inspect.to_s, type) end end
@justin808 you should probably remove hoe, which I believe managed gemspec type stuff before? |
Did that. Do you need me to help with the merge conflicts? |
Put both of you on developers, please. |
Not sure what you mean. |
Do you mean add us to the gemspec dev list? On Friday, July 25, 2014, Claudio Bustos [email protected] wrote:
Russ |
Exactly
|
done |
@justin808 you missed me :P |
Done now -- I had placed the commits on another branch and just fixed that. |
@justin808 this has merge conflicts :) |
@ukd1 Sorry, I missed your last comment until now. I just created a new PR that includes this change and some others. Maybe you can comment on that PR. I can revisit this one as well. |
I guess this is already considered in the other PR? Anyway, can you reopen it on sciruby/statsample, if necessary? Thanks! :) |
We need a gemspec