Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gemspec needed #24

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

justin808
Copy link
Contributor

We need a gemspec

Review on Reviewable

Second comparison of this method in awesome_print/formatter.rb causes
the crash.

Without this fix, pry + awesome_print cannot be used, as even a simple
case such as

[1, 2, 3].to_scale

will crash

    # Catch all method to format an arbitrary object.
    #------------------------------------------------------------------------------
    def awesome_self(object, type)
      if @options[:raw] && object.instance_variables.any?
        awesome_object(object)
      elsif object == ENV
        awesome_hash(object.to_hash)
      else
        colorize(object.inspect.to_s, type)
      end
    end
@justin808 justin808 changed the title Justin v 1.3.1 Gemspec needed Jul 14, 2014
@ukd1
Copy link
Contributor

ukd1 commented Jul 26, 2014

@justin808 you should probably remove hoe, which I believe managed gemspec type stuff before?

@justin808
Copy link
Contributor Author

Did that. Do you need me to help with the merge conflicts?

@clbustos
Copy link
Owner

Put both of you on developers, please.

@justin808
Copy link
Contributor Author

Not sure what you mean.

@ukd1
Copy link
Contributor

ukd1 commented Jul 26, 2014

Do you mean add us to the gemspec dev list?

On Friday, July 25, 2014, Claudio Bustos [email protected] wrote:

Put both of you on developers, please.


Reply to this email directly or view it on GitHub
#24 (comment).

Russ
Rainforest | +1-650-919-3216 | rainforestqa.com

@clbustos
Copy link
Owner

Exactly
El jul 25, 2014 10:58 p.m., "Russell Smith" [email protected]
escribió:

Do you mean add us to the gemspec dev list?

On Friday, July 25, 2014, Claudio Bustos [email protected]
wrote:

Put both of you on developers, please.


Reply to this email directly or view it on GitHub
#24 (comment).

Russ
Rainforest | +1-650-919-3216 | rainforestqa.com


Reply to this email directly or view it on GitHub
#24 (comment).

@justin808
Copy link
Contributor Author

done

@ukd1
Copy link
Contributor

ukd1 commented Jul 28, 2014

@justin808 you missed me :P

@justin808
Copy link
Contributor Author

Done now -- I had placed the commits on another branch and just fixed that.

@ukd1
Copy link
Contributor

ukd1 commented Jul 29, 2014

@justin808 this has merge conflicts :)

@justin808
Copy link
Contributor Author

@ukd1 Sorry, I missed your last comment until now. I just created a new PR that includes this change and some others. Maybe you can comment on that PR. I can revisit this one as well.

@agarie
Copy link

agarie commented Mar 18, 2015

I guess this is already considered in the other PR? Anyway, can you reopen it on sciruby/statsample, if necessary? Thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants