tests: mock network functions so tests work with no network #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI needs the fixes from #310 to work right. |
AdamWill
force-pushed
the
tests-no-network
branch
from
a8aad73
to
a3dbafe
Compare
AdamWill
changed the title
There's a few places where the tests implicitly need a network connection. Mainly, since the TDL XML test blocks in test_guest are for a subclass of RedHatLinuxCDYumGuest and specify a URL, we wind up hitting RedHatLinuxCDYumGuest._check_url which tries to get the headers for the URL to figure out if the server supports byte ranges. Let's just mock out the header retrieval to make that method happy. Secondly, test-53-command-http-url.tdl specifies an HTTP URL, so we wind up trying to retrieve it; mock out the actual download, since that's not what this test is really exercising. Signed-off-by: Adam Williamson <[email protected]>
AdamWill
force-pushed
the
tests-no-network
branch
from
a3dbafe
to
03edaa6
Compare
nullr0ute
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed this while trying to enable the tests in a package build.