Store TeX source #194
Merged
Store TeX source #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pihart
commented
Jun 17, 2021
| @@ -237,10 +238,10 @@ More details printed to console.` | |||
| return "invalid latex"; | |||
| } | |||
|
|
|||
| const img = await this.canvas.addImage( | |||
| const img: FabricTeXImage = await this.canvas.addImage( | |||
There was a problem hiding this comment.
This isn't really necessary (we don't care about how much stronger this type is than Image, just that it is Image) but it conveys intent
pihart
commented
Jun 17, 2021
| new Promise<fabric.Image>((resolve) => | ||
| options?: T | ||
| ): Promise<fabric.Image & (typeof options extends undefined ? unknown : T)> => | ||
| new Promise((resolve) => |
There was a problem hiding this comment.
We are now allowed to remove the redundant type from the new Promise() call!
pihart
commented
Jun 17, 2021
| @@ -42,6 +42,7 @@ export default class Pages { | |||
| savePage = (): void => { | |||
| this.pagesJSON[this.currentIndex] = this.canvas.toObject([ | |||
| "id", | |||
There was a problem hiding this comment.
This (the use of the artificial id property) should probably be abolished in the future; store in the data property instead
Open
cjquines
approved these changes
Jun 20, 2021
|
i've begun to change my mind and am tentatively approving this (sorry for not merging this before #189, but am still thinking about this) |
…opied to the `Object`
pihart
force-pushed
the
store-tex-source-193
branch
from
9de5292
to
c8c73d7
Compare
|
That's okay, things should be good now (conflict was due to rebasing #189 on merge, not due to doing it earlier) |
pihart
added
the
semver: minor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #193