Support attaching/detaching volumes on create/update instance #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vishal Anarase <[email protected]>
uzaxirr
force-pushed
the
volume-boot-attach
branch
from
b410d8f
to
61610a4
Compare
fernando-villalba
previously approved these changes
Oct 8, 2024
|
Testing now, this also needs to be documented before I approved |
| @@ -106,6 +106,20 @@ func ResourceInstance() *schema.Resource { | |||
| Description: "An optional list of tags, represented as a key, value pair", | |||
| Elem: &schema.Schema{Type: schema.TypeString}, | |||
| }, | |||
| "attached_volume": { | |||
There was a problem hiding this comment.
This should be attached_volumes. Otherwise it's confusing very confusing
There was a problem hiding this comment.
Ignore this as the struct is just for one volume, so it is correct
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.