Honouring write_kubeconfig post cluster creation #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rytswd
reviewed
Aug 16, 2024
| @@ -505,6 +515,13 @@ func resourceKubernetesClusterDelete(ctx context.Context, d *schema.ResourceData | |||
|
|
|||
| func customizeDiffKubernetesCluster(ctx context.Context, d *schema.ResourceDiff, meta interface{}) error { | |||
| if d.Id() != "" { | |||
There was a problem hiding this comment.
Not related to this change, but the check is getting rather lengthy and it is making harder to review. We should invert this check and early return instead.
if d.Id() == "" {
return errors.New("some error") //
}
if d.HasCHange("write_kubeconfig") {
...| @@ -445,6 +445,16 @@ func resourceKubernetesClusterUpdate(ctx context.Context, d *schema.ResourceData | |||
| if d.HasChange("write_kubeconfig") { | |||
| // setting atleast one field inside the KubernetesClusterConfig, just to ensure we are not sending an empty config | |||
| config.FirewallID = d.Get("firewall_id").(string) | |||
There was a problem hiding this comment.
I am guessing you don't need this line now then?
fernando-villalba
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here its necessary to set
firewall_idin thed.HasChange("write_kubeconfig")block so that in case where onlywrite_kubeconfigis changed we do not pass on an empty config struct in the update API call and it will fail.And since firewall is a required field. It does no harm in sending it as an update