-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Civo Kubernetes node pool configuration and organize code in their own folders per service #196
Conversation
…ode in they own folder per service Signed-off-by: Alejandro J. Nuñez Madrazo <[email protected]>
Signed-off-by: Alejandro J. Nuñez Madrazo <[email protected]>
Signed-off-by: Alejandro J. Nuñez Madrazo <[email protected]>
Signed-off-by: Alejandro J. Nuñez Madrazo <[email protected]>
…dencies Signed-off-by: Alejandro J. Nuñez Madrazo <[email protected]>
Signed-off-by: Alejandro J. Nuñez Madrazo <[email protected]>
Signed-off-by: Alejandro J. Nuñez Madrazo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now, a test (a function accepting t *testing.T
should be prefixed with Test<FunctionUnderTest>
, wondering why you removed this convention
Signed-off-by: Alejandro J. Nuñez Madrazo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seen some tests in a non-test file. The remaining things seem good!
Signed-off-by: Alejandro J. Nuñez Madrazo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This pull request refactors the Civo Kubernetes node pool configuration and organizes the code in their own folders per service. It also includes updates to the following files:
Signed-off-by: Alejandro J. Nuñez Madrazo [email protected]