Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GetInteriorHeading.md #936

Merged
merged 2 commits into from
Nov 26, 2023
Merged

Update GetInteriorHeading.md #936

merged 2 commits into from
Nov 26, 2023

Conversation

freedy69
Copy link
Contributor

Added information about the return value.

@freedy69
Update GetInteriorHeading.md
7e02a15 
Added information about return value
4mmonium
4mmonium suggested changes Nov 25, 2023
View reviewed changes
Copy link
Contributor

@4mmonium 4mmonium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey almost there, you forgot to add the alias for the native since you changed the function name 😊

INTERIOR/GetInteriorHeading.md Show resolved Hide resolved
INTERIOR/GetInteriorHeading.md Show resolved Hide resolved
INTERIOR/GetInteriorHeading.md Outdated
* **interior**: ID of the interior

## Return value
Returns interior heading in radians. Multiply the returned value with 57.29578 to get it in degrees.
Copy link
Contributor

@4mmonium 4mmonium Nov 25, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a quick note, that 57.29578 is the result of 180/Pi or 360/τ for people that prefer such.

Formulas

Name Mathematical Symbol Mathematical Formula Numerical Representation Conversion Formula to Degrees
Pi π π 3.14159... Radians * (180/3.14159)
Tau τ 2π 6.28318... Radians * (360/6.28318)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the return value text, how is it now?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the return value text, how is it now?

LGTM now, thank you 👍

@freedy69
Update GetInteriorHeading.md
79be2f6 
Added alias, added inroduction version back and changed return value text
@4mmonium 4mmonium merged commit a432c57 into citizenfx:master Nov 26, 2023
1 check passed
@freedy69 freedy69 deleted the patch-1 branch November 26, 2023 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@4mmonium 4mmonium 4mmonium approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@freedy69 @4mmonium