Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(natives/streaming): examples and updated natives for switch transition #935

Merged
merged 3 commits into from
Nov 24, 2023
Merged

feat(natives/streaming): examples and updated natives for switch transition #935

merged 3 commits into from
Nov 24, 2023

Conversation

spacevx
Copy link
Contributor

@spacevx spacevx commented Nov 23, 2023

  1. SetCloudHatOpacity:

    • Updated the native SetCloudHatOpacity.
    • Added a new example showcasing its usage.

  2. SwitchInPlayer and SwitchOutPlayer:

    • Made updates to SwitchInPlayer and SwitchOutPlayer natives.
    • Ensured consistency in the description and examples.

  3. GetPlayerSwitchState:

    • Updated the description and examples for the GetPlayerSwitchState native.

@AvarianKnight
Copy link
Collaborator

LGTM

4mmonium
4mmonium suggested changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@4mmonium 4mmonium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, looks good to me for the most part. I requested a couple changes for whenever you're free.

Copy pasted some of my comments for things that are 'redundant'.
Thank you for contributing! 😊

MISC/SetCloudsAlpha.md Outdated Show resolved Hide resolved
STREAMING/GetPlayerSwitchState.md Outdated Show resolved Hide resolved
STREAMING/SwitchToMultiSecondpart.md Show resolved Hide resolved
STREAMING/SwitchToMultiFirstpart.md Outdated Show resolved Hide resolved
STREAMING/SwitchToMultiFirstpart.md Show resolved Hide resolved
STREAMING/SwitchToMultiSecondpart.md Show resolved Hide resolved
@4mmonium
Update SwitchToMultiFirstpart.md
bdcf123 
Moved the note out of the code block.
@4mmonium
Update SetCloudsAlpha.md
1cb70cf 
Nitpicking on some grammar and slight correctness on what this native actually does.
4mmonium
4mmonium approved these changes Nov 24, 2023
View reviewed changes
Copy link
Contributor

@4mmonium 4mmonium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, thank you!

@4mmonium 4mmonium merged commit 99a7a82 into citizenfx:master Nov 24, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@4mmonium 4mmonium 4mmonium approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spacevx @AvarianKnight @4mmonium