Update SetMinimapComponent.md #932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add more component id's, an example and make some minor adjustments.
4mmonium
reviewed
Nov 8, 2023
4mmonium
reviewed
Nov 8, 2023
4mmonium
reviewed
Nov 8, 2023
4mmonium
reviewed
Nov 8, 2023
4mmonium
suggested changes
Nov 8, 2023
Reverted back to ID instead of id, and correct the return value to state that it is hardcoded to return 1. I'm going to leave the Any to int change as I think it would be better to specify it than not (However, I do see your point), if you desire it to be changed I'll do so.
Add info on componentID 9 and add information about what component IDs 6 through 14 are used for in the game.
|
I've gone over the requested changes and made some accommodations. On top of that, I added some additional info on componentID 9 and some general information about what componentIDs 6 through 14 are used for in the game. Thanks for reviewing the pull request so fast! |
Slight corrections to the markdown, moved hud colors to parameters section.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add more component id's, an example and make some minor adjustments.
Some images to "prove" that these new component id's are correct (areas toggled with hud colour 1; HUD_COLOUR_PURE_WHITE):
7: https://i.imgur.com/6jpbBR6.png
8 & 10: https://i.imgur.com/zsQMwer.png
11: https://i.imgur.com/UGxlhWO.png
12: https://i.imgur.com/FjDYQWW.png
13: https://i.imgur.com/tSrv2nc.png