-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update remaining VEHICLE namespace hashed natives #929
Conversation
Didnt mean to commit the second changes to this branch, but ill explain the changes here anyways. i went through and updated those that had already been solved and explained here: https://nativedb.dotindustries.dev/gta5/natives of course not everything will be 100% correct and ready to go, just request changes if you spot any issues! thanks |
Wasting your time if you're not automating the process. |
i dont want to automate it because i wanted to ensure they were correct, some had typos and so on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I review everything. Seems to be good. Missing a couple param's like I said. I'll maybe add more comments if @4mmonium wants to. Probably not a good idea to do BIG pr's like that since it takes a lot of times to review them in the future. Great PR tho! :D
|
||
```c | ||
// 0xB264C4D2F2B0A78B 0x45F72495 | ||
void _0xB264C4D2F2B0A78B(Vehicle vehicle); | ||
void ALLOW_AMBIENT_VEHICLES_TO_AVOID_ADVERSE_CONDITIONS(Vehicle vehicle); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Param is wrong. Should be a BOOL the allow or not.
|
||
```c | ||
// 0x2310A8F9421EBF43 | ||
void _0x2310A8F9421EBF43(Any p0); | ||
void ALLOW_TRAIN_TO_BE_REMOVED_BY_POPULATION(Any p0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Param is the vehicle id.
|
||
```c | ||
// 0xF78F94D60248C737 0x3B51B348 | ||
BOOL _0xF78F94D60248C737(Vehicle vehicle, BOOL p1); | ||
BOOL ARE_PLANE_CONTROL_PANELS_INTACT(Vehicle vehicle, BOOL p1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Param's are vehicle index and BOOL to check if health is at 0. R* seems to set this to false by default.
VEHICLE/CanCargobobPickUpEntity.md
Outdated
|
||
```c | ||
// 0x2C1D8B3B19E517CC | ||
Any _0x2C1D8B3B19E517CC(Any p0, Any p1); | ||
Any CAN_CARGOBOB_PICK_UP_ENTITY(Any p0, Any p1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Param are cargobob index and entity index.
--- | ||
ns: VEHICLE | ||
--- | ||
## DISABLE_VEHICLE_EXPLOSION_BREAK_OFF_PARTS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can add that this should be called every frame as the code re-enables this in every frame.
|
||
```c | ||
// 0x1F34B0626C594380 | ||
void SET_CARGOBOB_EXCLUDE_FROM_PICKUP_ENTITY(Any p0, Any p1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Param's are the cargobob index and the entity index.
|
||
```c | ||
// 0x72BECCF4B829522E | ||
void SET_CARGOBOB_EXTRA_PICKUP_RANGE(Any p0, Any p1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Param's are the vehicle index and the range increase.
|
||
```c | ||
// 0x56EB5E94318D3FB6 0x30F43FE3 | ||
void SET_CARGOBOB_PICKUP_MAGNET_ENSURE_PICKUP_ENTITY_UPRIGHT(Vehicle vehicle, BOOL p1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Second param is if it ensure the entity upright.
|
||
```c | ||
// 0x9BDDC73CC6A115D4 0x50CDB295 | ||
void SET_CARGOBOB_PICKUP_MAGNET_SET_AMBIENT_MODE(Vehicle vehicle, BOOL p1, BOOL p2); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
p1
is if it affects the vehicles and p2
if it affects the objects.
|
||
```c | ||
// 0xEF9D388F8D377F44 | ||
void _0xEF9D388F8D377F44(Vehicle vehicle, BOOL p1); | ||
void SET_CHECK_FOR_ENOUGH_ROOM_FOR_PED(Vehicle vehicle, BOOL p1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Second param is to check if it should check for enough room to fid the current ped.
added list of stations and lua example