Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Flag for StartShapeTestLosProbe #899

Merged
merged 8 commits into from
Aug 9, 2024
Merged

fix: Flag for StartShapeTestLosProbe #899

merged 8 commits into from
Aug 9, 2024

Conversation

JajarGaming
Copy link
Contributor

@JajarGaming JajarGaming commented Jul 25, 2023 •
edited
Loading

Found that the flag 511 is used the most in decompiled scripts

Fixed a flag...

@JajarGaming
Copy link
Contributor Author

Going to make the changes and tests sometime this week

@JajarGaming
Copy link
Contributor Author

Done

@JajarGaming JajarGaming changed the title missing flag for StartShapeTestLosProbe fixed flag for StartShapeTestLosProbe Jul 28, 2023
@JajarGaming JajarGaming changed the title fixed flag for StartShapeTestLosProbe fix: Flag for StartShapeTestLosProbe Sep 24, 2023
@PsychoShock
Copy link
Contributor

Still think that correct flag is 511 and not -1 from what I can see.

@JajarGaming
Copy link
Contributor Author

Still think that correct flag is 511 and not -1 from what I can see.

And yeah after further research I've noticed that as well

@AvarianKnight
Copy link
Collaborator

AvarianKnight commented Jan 2, 2024 •
edited
Loading

You should probably read @4mmonium's previous comment.

@AvarianKnight AvarianKnight added ready-to-merge needs validation This looks good, but needs additional confirmation of suggested change. and removed ready-to-merge labels Aug 7, 2024
@AvarianKnight
Copy link
Collaborator

You didn't rename p8 to options in the function declaration

@AvarianKnight AvarianKnight added ready-to-merge and removed needs validation This looks good, but needs additional confirmation of suggested change. labels Aug 9, 2024
@AvarianKnight AvarianKnight merged commit 9d6308f into citizenfx:master Aug 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Disquse Disquse Disquse left review comments

@AvarianKnight AvarianKnight AvarianKnight left review comments

@gottfriedleibniz gottfriedleibniz gottfriedleibniz left review comments

@4mmonium 4mmonium 4mmonium left review comments

@FlawwsX FlawwsX FlawwsX left review comments

@PsychoShock PsychoShock PsychoShock approved these changes

Assignees
No one assigned
Labels
ready-to-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@JajarGaming @PsychoShock @AvarianKnight @Disquse @gottfriedleibniz @4mmonium @FlawwsX