Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SetAllRandomPedsFlee.md #779

Merged
merged 6 commits into from
Nov 2, 2023
Merged

Conversation

FarmerKarwer
Copy link
Contributor

@FarmerKarwer FarmerKarwer commented Jun 22, 2022

I gave the description of this command. It sets whether all random peds will run away from player if one attacks or harasses them (bool=true), or some peds can stand up for themselves (bool=false).

I gave the description of this command.
@@ -8,6 +8,7 @@ ns: PLAYER
void SET_ALL_RANDOM_PEDS_FLEE(Player player, BOOL toggle);
```

Sets whether all random peds will run away from player if one attacks or harasses them (bool=true), or some peds can stand up for themselves (bool=false).

## Parameters
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind giving the parameters a description to wrap this up? Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind giving the parameters a description to wrap this up? Thanks!

Done!

Copy link
Contributor

@4mmonium 4mmonium Jun 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, if you can, do please take a look at @gottfriedleibniz's comment, he makes a great point.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok=)

@gottfriedleibniz
Copy link
Contributor

gottfriedleibniz commented Jun 22, 2022

Instead of "attacks or harasses them", it may be better to use "agitated" (and/or "threatened") (e.g., "when agitated or threatened by ...") as it uses the same language from gamecode (class CAgitatedConditionCanFight: CAgitatedCondition).


## Parameters
* **player**:
* **toggle**:
* **player**: PLAYER::PLAYER_ID()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "The player to set this to i.e. PlayerId()" would be a better description.

Some slight corrections regarding the native description and the player parameter.
Correct the description and player parameter once more.
@4mmonium 4mmonium merged commit e3a8168 into citizenfx:master Nov 2, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants