-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
correct names and parameter names for air defence natives #1205
base: master
Are you sure you want to change the base?
Conversation
int CREATE_AIR_DEFENCE_ANGLED_AREA(float srcCoord1X, float srcCoord1Y, float srcCoord1Z, float srcCoord2X, float srcCoord2Y, float srcCoord2Z, float fWidth, float weaponPositionX, float weaponPositionY, float weaponPositionZ, cs_type(Any) Hash weaponHash); | ||
``` | ||
|
||
## Parameters |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide the following if possible:
- Parameter descriptions
- Return value description
- Native description
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know how they work which is why the documentation is missing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as #1204 (comment)
WEAPON/CreateAirDefenceSphere.md
Outdated
* **p4**: X coordinate | ||
* **p5**: Y coordinate | ||
* **p6**: Z coordinate | ||
* **weaponPositionX**: X coordinate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Specify the differences between the 2 sets of coords passed to the native. Having just "X coordinate" isn't very helpful as the name tells us that, would be better to be something more like "X coordinate of the weapon position" or whatever is applicable for this case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here, i've removed the undescriptive "X coordinate" now
No description provided.