Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tweak: change image host provider #1174

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

userMacieG
Copy link

No description provided.

@userMacieG
Copy link
Author

citizenfx/fivem-docs#475

@colistro123
Copy link
Contributor

colistro123 commented Aug 24, 2024

This approach may not be ideal, as it introduces an additional repository as a dependency, specifically fivem-docs. Consequently, every time someone wants to add an image, they will also need to update that repository. This issue has been discussed here.

Just my two cents here, but a more efficient solution could involve using a serverless AWS Lambda function (which can be implemented in Python, Node.js or any other supported language) in conjunction with an S3 bucket. This setup would allow users to upload images directly and serve the URLs on server response, making it easier to integrate them into the native documentation without the need for updates to the fivem-docs repository.

@userMacieG
Copy link
Author

userMacieG commented Aug 25, 2024

But for now just to have working images, this is in my opinion best approach

@AvarianKnight AvarianKnight self-assigned this Sep 10, 2024
@VIRUXE
Copy link

VIRUXE commented Sep 26, 2024

I think my implementation is better. #1125

@userMacieG
Copy link
Author

@VIRUXE ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants