Update EnableAllControlActions.md #1171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added CAMERA_CONTROL enum which was unknown.
colistro123
reviewed
Aug 24, 2024
There was a problem hiding this comment.
Just suggesting general feedback here, updating the parameters to controlType would result in inconsistencies between native parameters across files.
To maintain consistency, it's best to leave the existing parameters as padIndex and introduce the new ePadType enum.
If you prefer to maintain the controlType naming convention, you could update all the other files that reference padIndex to use controlType 😊
Co-authored-by: UTIL_TRACELINE <[email protected]>
Co-authored-by: UTIL_TRACELINE <[email protected]>
AvarianKnight
requested changes
Aug 26, 2024
Co-authored-by: UTIL_TRACELINE <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added CAMERA_CONTROL enum which was unknown.
Before you submit this PR, please make sure: