Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(natives/object): add documentation for DELETE_OBJECT #1163

Merged
merged 2 commits into from
Aug 23, 2024

Conversation

spacevx
Copy link
Contributor

@spacevx spacevx commented Aug 15, 2024

  • Add documentation for DELETE_OBJECT
  • Add examples (Lua, JS, C#)
  • A note about some entities who can't be deleted

Copy link
Collaborator

@AvarianKnight AvarianKnight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

object is a reserved word in c#

OBJECT/DeleteObject.md Outdated Show resolved Hide resolved
OBJECT/DeleteObject.md Outdated Show resolved Hide resolved
OBJECT/DeleteObject.md Outdated Show resolved Hide resolved
* Add documentation for DELETE_OBJECT
* Add examples (Lua, JS, C#)
* A note about some entites who can't be deleted

Co-Authored-By: Dillon Skaggs <[email protected]>
@AvarianKnight AvarianKnight added the examples need testing Examples need testing to ensure that they work label Aug 19, 2024
@spacevx
Copy link
Contributor Author

spacevx commented Aug 19, 2024

Those examples were tested (Lua, JS) by deleting objects in an IPL (several chairs), using SetEntityAsMissionEntity to get control and allow the use of DeleteObject who wasn't working without the SetEntityAsMissionEntity

@AvarianKnight AvarianKnight added ready-to-merge and removed examples need testing Examples need testing to ensure that they work labels Aug 21, 2024
OBJECT/DeleteObject.md Outdated Show resolved Hide resolved
OBJECT/DeleteObject.md Outdated Show resolved Hide resolved
OBJECT/DeleteObject.md Outdated Show resolved Hide resolved
OBJECT/DeleteObject.md Outdated Show resolved Hide resolved
@AvarianKnight AvarianKnight merged commit 331a50c into citizenfx:master Aug 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants