add tcp client to acceptance test

cisco-open · Jul 13, 2023 · 6ceeb53 · 6ceeb53
1 parent 4c72882
commit 6ceeb53
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 1 deletion.
diff --git a/.github/workflows/acceptance-test.yaml b/.github/workflows/acceptance-test.yaml
@@ -75,3 +75,8 @@ jobs:
           make run-client
         env:
           CLIENT_REQUEST_URL: "http://echo.testing:80"
+
+      - name: Run simple go tcp client (istioctl)
+        working-directory: examples/tcp
+        run: |
+          make run-client
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
@@ -16,6 +16,10 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
+      - name: Install CA certificates
+        run: |
+          sudo apt-get -y install ca-certificates
+        
       - name: Check out code
         uses: actions/checkout@v3
 

diff --git a/pkg/proxywasm/data_store.go b/pkg/proxywasm/data_store.go
@@ -66,7 +66,7 @@ func (s *urlDataSource) Get() ([]byte, error) {
 		return s.bytes, nil
 	}
 
-	resp, err := s.httpGetter.Get(s.url) //nolint:noctx
+	resp, err := s.httpGetter.Get(s.url)
 	if err != nil {
 		return nil, errors.WrapIfWithDetails(err, "could not parse url", "url", s.url)
 	}