fix sfn execution retrieval #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6 +/- ##
==========================================
+ Coverage 66.43% 69.40% +2.97%
==========================================
Files 8 8
Lines 572 572
==========================================
+ Hits 380 397 +17
+ Misses 192 175 -17
☔ View full report in Codecov by Sentry. |
jkeifer
approved these changes
Oct 30, 2023
ircwaves
force-pushed
the
get-correct-sfn-exec
branch
from
0c82883
to
0ea5129
Compare
ircwaves
force-pushed
the
get-correct-sfn-exec
branch
from
0cf17fe
to
3542bcb
Compare
|
@jkeifer - the feedback mechanism of seeing 0% patch coverage caused me to add a test, along with some changes to make the test function. A coarse and quick second look would be appreciated. Also, it seems like you were able to bonk the tests to have them rerun with successful coverage upload, and my pushing these new commits leads them to fail coverage upload again. Feels very much like I'm going to have to learn about GitHub actions, though I prefer GitLab CI tremendously. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StepFunctions executions are appended to the list stored in each StateDB item, so this modifies the code to grab the most recent execution.