Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to support workflow event manager #12

Merged

Conversation

ircwaves
Copy link
Member

No description provided.

@ircwaves ircwaves force-pushed the update-to-support-workflow-event-manager branch from f4de0ef to d9e607c Compare May 14, 2024 15:31
Copy link

codecov bot commented May 14, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 70.89%. Comparing base (715a155) to head (4b33b0f).

Files Patch % Lines
src/cirrus/plugins/management/deployment.py 77.77% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #12      +/-   ##
==========================================
+ Coverage   70.78%   70.89%   +0.10%     
==========================================
  Files           8        8              
  Lines         575      584       +9     
==========================================
+ Hits          407      414       +7     
- Misses        168      170       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ircwaves ircwaves force-pushed the update-to-support-workflow-event-manager branch from 5e65f46 to 4b33b0f Compare May 14, 2024 20:04
Copy link
Member

@jkeifer jkeifer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is still a draft but I'm happy to approve in the current state. If any substantial changes might need to go in after this point just let me know to re-review.

@ircwaves ircwaves marked this pull request as ready for review May 15, 2024 00:43
@ircwaves ircwaves merged commit 39a8a94 into cirrus-geo:main May 15, 2024
6 checks passed
@ircwaves ircwaves deleted the update-to-support-workflow-event-manager branch May 15, 2024 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants